Fixed primary shard balance constraints getting unset #15996
Conversation
patelsmit32123
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@peternied Can you please review? |
|
❌ Gradle check result for 360fbfa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
patelsmit32123
force-pushed
the
fix-shard-balance-constraints-unset
branch
from
360fbfa to
f161334
Compare
|
❌ Gradle check result for f161334: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Smit Patel <[email protected]>
patelsmit32123
force-pushed
the
fix-shard-balance-constraints-unset
branch
from
f161334 to
ca907c7
Compare
|
❕ Gradle check result for ca907c7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15996 +/- ##
============================================
+ Coverage 71.90% 71.99% +0.08%
- Complexity 64392 64393 +1
============================================
Files 5278 5280 +2
Lines 300877 300875 -2
Branches 43478 43477 -1
============================================
+ Hits 216351 216619 +268
+ Misses 66747 66474 -273
- Partials 17779 17782 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@patelsmit32123 Thanks for making this change and reaching out. @gbbafna @Bukhtawar @ashking94 Could one of you review this PR in my place? |
Hi @peternied, I will review this. Thanks @patelsmit32123 for making this change. Allow me some time to go over this. |
|
@ashking94 how to test the scenario? The problem is that the allocation constraints which are getting unset, they are not accessible from outside. |
Can we add some unit tests to ascertain that the behaviour works as expected? I see BalancedSingleShardTests where you can attempt to put the test against the delta. Let me know if this does not work. |
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
Description
Fixed updating shard balance factor and other such settings were unsetting the prefer primary shard balance constraints.
Related Issues
#13429
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.